Set the right DebugType and Optimize settings for the Methodical merged test runners#122306
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Dec 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing DebugType and Optimize settings to the Methodical merged test runner project files. These settings were missed when the individual tests were consolidated into runner projects, and this change ensures proper build configurations are applied to each test variant.
- Adds
<DebugType>property to all six Methodical test runner variants (_d1, _d2, _do, _r1, _r2, _ro) - Adds
<Optimize>true</Optimize>property to the _ro and _do variants - Fixes trailing whitespace issue in _r2 and _d2 project files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/JIT/Methodical/Methodical_ro.csproj | Adds DebugType=none and Optimize=true for release optimized tests |
| src/tests/JIT/Methodical/Methodical_r2.csproj | Adds DebugType=none and fixes trailing whitespace for release tier 2 tests |
| src/tests/JIT/Methodical/Methodical_r1.csproj | Adds DebugType=none for release tier 1 tests |
| src/tests/JIT/Methodical/Methodical_do.csproj | Adds DebugType=full and Optimize=true for debug optimized tests |
| src/tests/JIT/Methodical/Methodical_d2.csproj | Adds DebugType=full and fixes trailing whitespace for debug tier 2 tests |
| src/tests/JIT/Methodical/Methodical_d1.csproj | Adds DebugType=full for debug tier 1 tests |
davidwrighton
approved these changes
Dec 8, 2025
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These settings got missed when we merged the tests into the runner.